On Tue, Sep 13, 2022 at 06:40:23PM +0930, Joel Stanley wrote: > From: Johannes Holland <johannes.holland@xxxxxxxxxxxx> > Not really v1. And there was v19 that I already reviewed... > Add a YAML schema to support device tree bindings for the generic I2C s/YAML/DT/ > physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP) > Specification for TPM 2.0 v1.04 Revision 14. > > This includes descriptions for the Nuvoton and Infineon devices. > > Signed-off-by: Johannes Holland <johannes.holland@xxxxxxxxxxxx> > Signed-off-by: Joel Stanley <joel@xxxxxxxxx> > --- > .../bindings/security/tpm/tpm-tis-i2c.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > new file mode 100644 > index 000000000000..fb7b747ff2a5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/security/tpm/tpm-tis-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: I2C PTP based TPM Device Tree Bindings s/Device Tree Bindings/Devices/ > + > +maintainers: > + - Johannes Holland <johannes.holland@xxxxxxxxxxxx> > + > +description: > + Device Tree Bindings for I2C based Trusted Platform Module (TPM). > + > +properties: > + $nodename: > + pattern: "^tpm(@[0-9a-f]+)?$" > + > + compatible: > + oneOf: > + - description: Infineon's Trusted Platform Module (TPM) (SLB9673). > + items: > + - const: infineon,slb9673 You need to remove from trivial-devices.yaml. A revert of [1] perhaps. > + - description: Nuvoton's Trusted Platform Module (TPM) (NPCT75x). > + items: > + - const: nuvoton,npct75x > + - const: tcg,tpm-tis-i2c > + - const: tcg,tpm-tis-i2c > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tpm@2e { > + compatible = "nuvoton,npct75x", "tcg,tpm-tis-i2c"; > + reg = <0x2e>; > + }; > + }; > +... > -- > 2.35.1 > > [1] https://lore.kernel.org/all/20220608173113.9232-2-Alexander.Steffen@xxxxxxxxxxxx/