On 13/09/2022 08:37, Claudiu.Beznea@xxxxxxxxxxxxx wrote: > On 09.09.2022 19:30, Jerry Ray wrote: >> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for >> evaluating many Microchip ethernet switch and PHY products. Various >> daughter cards can connect via an RGMII connector or an RMII connector. >> >> The EDS board is not intended for stand-alone use and has no ethernet >> capabilities when no daughter board is connected. As such, this device >> tree is intended to be used with a DT overlay defining the add-on board. >> To better ensure consistency, some items are defined here as a form of >> documentation so that all add-on overlays will use the same terms. >> >> Link: https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVELOPMENT-SYSTEM >> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx> >> --- >> v8->v9: >> - Changed node name from gpio to gpio-inputs > > Why not gpio-keys as all other DTSes are doing? Anyway, I can change it > while applying. +1 even if these are not physical keys. If we ever run sed pattern, it would make life easier... :) Best regards, Krzysztof