Hi Arnd, On 2022/09/12 17:36, Arnd Bergmann wrote:
On Mon, Sep 12, 2022, at 9:15 AM, Kunihiko Hayashi wrote:Add ahci controller and glue layer nodes including reset and phy. This supports for PXs2 and the boards without PXs2 vodka board that doesn't implement any SATA connectors. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx> + ahci: ahci@65600000 { + compatible = "socionext,uniphier-pxs2-ahci", + "generic-ahci"; + status = "disabled"; + reg = <0x65600000 0x10000>; + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sys_clk 28>; + resets = <&sys_rst 28>, <&ahci_rst 0>; + ports-implemented = <1>; + phys = <&ahci_phy>; + }; + + ahci-glue@65700000 { + compatible = "socionext,uniphier-pxs2-ahci-glue", + "simple-mfd";Here as well, the "ahci-glue" name seems rather unusual for a node name. What does it actually do, and why is this not just part of the sata node?
According to ata/sata-common.yaml, "ahci@65600000" node for generic SATA host controller is better expressed as "sata@65600000". I'll fix it. However, "ahci-glue@65700000" is the integration of SATA related functions (reset and phy). Maybe "sata-controller" seems to be the best, but I couldn't find this usage.
+ #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x65700000 0x100>; + + ahci_rst: reset@0 { + compatible ="socionext,uniphier-pxs2-ahci-reset"; I think the node name here should be "reset-controller@0".
Yes, I'll fix it.
+ + ahci_phy: phy@10 { + compatible ="socionext,uniphier-pxs2-ahci-phy"; and "sata-phy@10" here.
I'll fix it too. Thank you, --- Best Regards Kunihiko Hayashi
