Hi Mark (x2 :)) 2014-10-13 12:10 GMT+02:00 Mark Brown <broonie@xxxxxxxxxx>: > On Mon, Oct 13, 2014 at 11:05:04AM +0100, Mark Rutland wrote: >> On Sun, Oct 12, 2014 at 10:39:11PM +0100, Jean-Michel Hautbois wrote: >> > Some systems may require a different resistor than the default one (4K). >> > This adds a property in sgtl5000 codec. >> > It keeps the default of 4K when nothing is specified so it does not break >> > existing code. >> > >> > v2: modify the default case on DT parsing > > Don't include noise like this in the changelog, add it after the --- as > covered in SubmittingPatches. Oups, not intended, too quick to commit sorry... >> > +- sgtl5000-micbias-resistor : the bias resistor to be used >> > + 1 or SGTL5000_MICBIAS_2K - MICBIAS resistor is set to 2K >> > + 2 or SGTL5000_MICBIAS_4K - MICBIAS resistor is set to 4K >> > + 3 or SGTL5000_MICBIAS_8K - MICBIAS resistor is set to 8K >> > + 0 or SGTL5000_MICBIAS_OFF - MICBIAS resistor is not used >> > + If this node is not mentioned or if the value is unknown, then >> > + micbias resistor is set to 4K. > >> The SGTL5000_MICBIAS_* constants aren't in a DT header, so shouldn't be >> referenced here. > > Or the constants should be moved of course but... > >> Why not have mcbias-resistor-k-ohms as 2, 4, 8, or 0? > >> That would be much easier to read as a human. > > ...this is even better. Yes, I will do that ASAP, and base the micbias-voltage on the same principle. Thanks, JM -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
