On 2022-09-10 11:57:34 +0200, Krzysztof Kozlowski wrote: > On 09/09/2022 15:50, Janne Grunau wrote: > > This adds the following apple,t6001 platform: > > > > - apple,j375c - Mac Studio (M1 Max, 2022) > > > > And the initial apple,t6002 platform: > > > > - apple,j375d - Mac Studio (M1 Ultra, 2022) > > > > Signed-off-by: Janne Grunau <j@xxxxxxxxxx> > > --- > > > > Documentation/devicetree/bindings/arm/apple.yaml | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > > index 8d93e8a6cc18..b34e56b9dc59 100644 > > --- a/Documentation/devicetree/bindings/arm/apple.yaml > > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > > @@ -19,12 +19,14 @@ description: | > > - MacBook Air (M1, 2020) > > - iMac (24-inch, M1, 2021) > > > > - And devices based on the "M1 Pro" and "M1 Max" SoCs: > > + And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: > > > > - MacBook Pro (14-inch, M1 Pro, 2021) > > - MacBook Pro (14-inch, M1 Max, 2021) > > - MacBook Pro (16-inch, M1 Pro, 2021) > > - MacBook Pro (16-inch, M1 Max, 2021) > > + - Mac Studio (M1 Max, 2022) > > + - Mac Studio (M1 Ultra, 2022) > > > > The compatible property should follow this format: > > > > @@ -79,8 +81,15 @@ properties: > > - enum: > > - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021) > > - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021) > > + - apple,j375c # Mac Studio (M1 Max, 2022) > > - const: apple,t6001 > > - const: apple,arm-platform > > Blank line. Added. The other entries in this list are not separated by blank lines. What would preferred to fix this? A whitespace only patch or can just add those additional blank lines in this change? > > + - description: Apple M1 Ultra SoC based platforms > > With this: > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Thanks, Janne
