On 09/09/2022 19:55, Sebastian Reichel wrote: > Add DT binding document for Rockchip's RK806 PMIC. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > + vcc11-supply: > + description: > + The input supply for pldo-reg1, pldo-reg2 and pldo-reg3. > + > + vcc12-supply: > + description: > + The input supply for pldo-reg4 and pldo-reg5. > + > + vcc13-supply: > + description: > + The input supply for nldo-reg1, nldo-reg2 and nldo-reg3. > + > + vcc14-supply: > + description: > + The input supply for nldo-reg4 and nldo-reg5. > + > + vcca-supply: > + description: > + The input supply for pldo-reg6. > + > + regulators: > + type: object > + patternProperties: > + "^(dcdc-reg([1-9]|10)|pldo-reg[1-6]|nldo-reg[1-5])$": > + type: object > + $ref: /schemas/regulator/regulator.yaml# > + unevaluatedProperties: false Sorry, for not spotting it earlier but the indentation here looks wrong. On "patternProperties" indentation you need additionalProperties: false, because only the patterns are allowed. On "$ref: ....." level of indentation, you need unevaluatedProperties: false, because you allow only properties previously evaluated (evaluated by regulator.yaml). Best regards, Krzysztof
