On 9 September 2022 19:44:11 GMT+03:00, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: >On 09/09/2022 17:03, Dmitry Baryshkov wrote: >>>> + then: >>>> + properties: >>>> + clocks: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + clock-names: >>>> + minItems: 1 >>>> + items: >>>> + - const: slave_iface >>>> + - const: pxo >>> >>> Why pxo is optional? Commit msg does not say much here. >> >> It's optional as it is not present in current DT files. The driver will >> fallback to 'pxo_board' if the clock is not present. >> >>> It seems you also miss the DTS change adding the clock. >> >> Oh, I'll add it to v2. > >How about adding it to DTS and making it required in the bindings? I did >not check the driver, but isn't the driver fail if clock is missing thus >the clock is really required? I had the impression that we cannot make a clock mandatory of it wasn't present before. Please correct me if I'm wrong. No, the driver will not fail. It will fallback to the lookup of the `pxo_board' clock from the system clock list. -- With best wishes Dmitry
