> On 9. 9. 2022, at 16:47, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 09/09/2022 15:53, Martin Povišer wrote: >> The CS42L83 part is a headphone jack codec found in recent Apple >> machines. It is a publicly undocumented part but as far as can be told >> it is identical to CS42L42 except for two points: >> (...) >> +static const struct dev_pm_ops cs42l83_i2c_pm_ops = { >> + SET_SYSTEM_SLEEP_PM_OPS(cs42l42_suspend, cs42l83_i2c_resume) >> +}; >> + >> +static const struct of_device_id __maybe_unused cs42l83_of_match[] = { >> + { .compatible = "cirrus,cs42l83", }, >> + {} >> +}; >> +MODULE_DEVICE_TABLE(of, cs42l83_of_match); >> + >> +static struct i2c_driver cs42l83_i2c_driver = { >> + .driver = { >> + .name = "cs42l83", >> + .pm = &cs42l83_i2c_pm_ops, >> + .of_match_table = of_match_ptr(cs42l83_of_match), > > This should complain with compile testing. Usually it comes with > __maybe_unused/ Which symbol? cs42l83_of_match has maybe_unused. Best, Martin > > > Best regards, > Krzysztof