Lee Jones <lee@xxxxxxxxxx> 于2022年9月9日周五 19:50写道: > > On Fri, 09 Sep 2022, Krzysztof Kozlowski wrote: > > > On 09/09/2022 12:16, Cixi Geng wrote: > > > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 于2022年9月9日周五 17:57写道: > > >> > > >> On 09/09/2022 11:50, Cixi Geng wrote: > > >>> Lee Jones <lee@xxxxxxxxxx> 于2022年9月9日周五 16:10写道: > > >>>> > > >>>> On Fri, 09 Sep 2022, Cixi Geng wrote: > > >>>> > > >>>>> From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > > >>>>> > > >>>>> Add bindings for Unisoc system global register which provide register map > > >>>>> for clocks. > > >>>>> > > >>>>> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > > >>>>> Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx> > > >>>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > >>>>> --- > > >>>>> .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > > >>>>> 1 file changed, 68 insertions(+) > > >>>>> create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > > >>>> > > >>>> I'll take this when the clk driver changes are merged. > > >>> this patch is depends on the clk dt-bingdings, which is already merged [1] > > >> > > >> which is merged to different tree, so this one here cannot go via MFD > > >> tree without cross-tree merges. > > > Hi Krzysztof: > > > I test on the latest kernel 506357871c18e06565840d71c2ef9f818e19f460 > > > (torvalds/master) version:6.0.0.rc4 > > > what you mean is I must warting your branch upgrade the cross-tree? > > > > Ah, you linked email message so that rather indicated applying to clk > > tree, but indeed it is already in the mainline. > > ... and also, I'm *still* not playing that game with DT bindings. > > It's bad enough that we have to sync across subsystems to avoid > build-breakages. If documentation comes together in -next and > subsequently Mainline that should be adequate. > > I doubt Linus is running DT checker(s) on each pull-request he merges, > nor are there any stipulations for DT bindings to be bisectable > post-merge. Thanks Lee and Krzysztof's review. I wiil send the patch a new version to add the adress-cell const property.and I think we have agreed on that the dependent patch already exist in mainline. so these patches can applied as long as no other issues. Best regards, Cixi > > -- > Lee Jones [李琼斯]