On Sun, Oct 12, 2014 at 3:39 PM, Jean-Michel Hautbois <jean-michel.hautbois@xxxxxxxxxxx> wrote: > + if (np) { > + if (!of_property_read_u32(np, > + "sgtl5000-micbias-resistor", &value)) { > + switch (value) { > + case 1: > + sgtl5000->micbias_resistor = > + SGTL5000_MICBIAS_2K; > + break; > + case 2: > + sgtl5000->micbias_resistor = > + SGTL5000_MICBIAS_4K; > + break; > + case 3: > + sgtl5000->micbias_resistor = > + SGTL5000_MICBIAS_8K; > + break; > + default: > + sgtl5000->micbias_resistor = > + SGTL5000_MICBIAS_OFF; > + dev_err(&client->dev, > + "Unsuitable MicBias resistor\n"); The case 0 should SGTL5000_MICBIAS_OFF and the default should be SGTL5000_MICBIAS_4K. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html