On Thu, Sep 8, 2022 at 2:19 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote: > > Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board. > > > > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > > Cc: Fabio Estevam <festevam@xxxxxxxxx> > > Cc: NXP Linux Team <linux-imx@xxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7431579ab0e8..ce89fac1898e 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -831,6 +831,7 @@ properties: > > - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board > > - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board > > - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board > > + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board > > A useful comment would be ones that distuiguish these boards. It's > obvious from the compatible it's a i.MX8MM board from Gateworks. But isn't it clear that you need to go to the device-tree itself to understand the details? As far as basic features go sometimes there is very little difference in these board models. It would be a struggle to list all the board details (which I do in the dts commit) in a way that doesn't take up too much space in fsl.yaml. Best Regards, Tim
