On 08/09/2022 02:31, Sebastian Reichel wrote: > Add DT binding document for Rockchip's RK806 PMIC. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > + vcca-supply: > + description: > + The input supply for pldo-reg6. > + > + regulators: > + type: object > + patternProperties: > + "^(dcdc-reg([1-9]|10)|[pn]ldo_reg[1-6])$": You still have underscore in the pattern. This should pop-up during test: please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof