> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: Wednesday, September 7, 2022 4:56 PM > To: Smitha T Murthy <smitha.t@xxxxxxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; > mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > ezequiel@xxxxxxxxxxxxxxxxxxxx; jernej.skrabec@xxxxxxxxx; > benjamin.gaignard@xxxxxxxxxxxxx; stanimir.varbanov@xxxxxxxxxx; > dillon.minfei@xxxxxxxxx; david.plowman@xxxxxxxxxxxxxxx; > mark.rutland@xxxxxxx; robh+dt@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; > andi@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; > aakarsh.jain@xxxxxxxxxxx > Subject: Re: [Patch v2 15/15] arm64: dts: fsd: Add MFC related DT enteries > > On 07/09/2022 08:47, Smitha T Murthy wrote: > > Add MFC DT node and reserve memory node for MFC usage. > > > > Cc: linux-fsd@xxxxxxxxx > > Signed-off-by: Smitha T Murthy <smitha.t@xxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++ > > arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++++++++++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts > b/arch/arm64/boot/dts/tesla/fsd-evb.dts > > index 1db6ddf03f01..17bb048f9d47 100644 > > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > > @@ -30,6 +30,10 @@ > > }; > > }; > > > > +&clock_mfc { > > + status = "okay"; > > clock node was never disabled, so there is no need to enable it. > Ok I will remove it in the next series. > > +}; > > + > > &fin_pll { > > clock-frequency = <24000000>; > > }; > > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi > b/arch/arm64/boot/dts/tesla/fsd.dtsi > > index f35bc5a288c2..bca0ba030ee7 100644 > > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi > > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi > > @@ -340,6 +340,18 @@ > > #clock-cells = <0>; > > }; > > > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + mfc_left: region@84000000 { > > + compatible = "shared-dma-pool"; > > + no-map; > > + reg = <0 0x84000000 0 0x8000000>; > > + }; > > + }; > > + > > soc: soc@0 { > > compatible = "simple-bus"; > > #address-cells = <2>; > > @@ -832,6 +844,16 @@ > > clock-names = "fin_pll", "mct"; > > }; > > > > + mfc: mfc@12880000 { > > + compatible = "samsung,fsd-mfc"; > > + reg = <0x0 0x12880000 0x0 0x10000>; > > + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>; > > + clock-names = "mfc"; > > + clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>; > > + memory-region = <&mfc_left>; > > + status = "okay"; > > Okay is by default, don't add it. > I will remove this in the next series. > > + }; > > + > > ufs: ufs@15120000 { > > compatible = "tesla,fsd-ufs"; > > reg = <0x0 0x15120000 0x0 0x200>, /* 0: HCI standard > */ > > > Best regards, > Krzysztof Thank you for the review. Regards, Smitha
