On 06/09/2022 19:46, Rob Herring wrote: > On Tue, 06 Sep 2022 14:16:52 +0200, Krzysztof Kozlowski wrote: >> The APR bindings were not describing properly children nodes for DAIs. >> None of the DTSes use unit addresses for the children, so correct the >> nodes and reference their schema: clock-controller, dais and routing. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> .../bindings/soc/qcom/qcom,apr.yaml | 38 +++++++++++++------ >> .../sound/qcom,q6dsp-lpass-clocks.yaml | 16 ++------ >> .../sound/qcom,q6dsp-lpass-ports.yaml | 16 ++------ >> 3 files changed, 35 insertions(+), 35 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dtb: gpr: service@1: '#address-cells', '#size-cells', 'apm-dai@1' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml I missed one more place with example to fix. Best regards, Krzysztof