On Tue, Sep 06, 2022 at 11:13:41AM +0000, Joy Zou wrote: > > > -----Original Message----- > > From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > Sent: 2022年9月6日 18:55 > > To: Joy Zou <joy.zou@xxxxxxx> > > Cc: vkoul@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; > > festevam@xxxxxxxxx; S.J. Wang <shengjiu.wang@xxxxxxx>; > > martink@xxxxxxxxx; dev@xxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>; > > david@xxxxxxx; aford173@xxxxxxxxx; Hongxing Zhu <hongxing.zhu@xxxxxxx>; > > dl-linux-imx <linux-imx@xxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx > > Subject: [EXT] Re: [PATCH v6 1/4] dt-bindings: fsl-imx-sdma: Convert imx sdma > > to DT schema > > > > Caution: EXT Email > > > > Hi, > > > > thanks for the YAML conversion patch. > > > > Am Dienstag, 6. September 2022, 11:42:53 CEST schrieb Joy Zou: > > > Convert the i.MX SDMA binding to DT schema format using json-schema. > > > > > > The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma, > > > fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to > > > delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and > > > fsl,imx6sl-sdma are added. The original binding don't list all compatible used. > > > > > > In addition, add new peripheral types HDMI Audio. > > > > > > Signed-off-by: Joy Zou <joy.zou@xxxxxxx> > > > --- > > > Changes in v6: > > > delete tag Acked-by from commit message. > > > > > > Changes in v5: > > > modify the commit message fromat. > > > add additionalProperties, because delete the quotes in patch v4. > > > delete unevaluatedProperties due to similar to additionalProperties. > > > modification fsl,sdma-event-remap items and description. > > > > > > Changes in v4: > > > modify the commit message. > > > delete the quotes in patch. > > > modify the compatible in patch. > > > delete maxitems and add items for clock-names property. > > > add iram property. > > > > > > Changes in v3: > > > modify the commit message. > > > modify the filename. > > > modify the maintainer. > > > delete the unnecessary comment. > > > modify the compatible and run dt_binding_check and dtbs_check. > > > add clocks and clock-names property. > > > delete the reg description and add maxItems. > > > delete the interrupts description and add maxItems. > > > add ref for gpr property. > > > modify the fsl,sdma-event-remap ref type and add items. > > > delete consumer example. > > > > > > Changes in v2: > > > convert imx sdma bindings to DT schema. > > > --- > > > .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 147 > > > ++++++++++++++++++ .../devicetree/bindings/dma/fsl-imx-sdma.txt | > > > 118 -------------- > > > 2 files changed, 147 insertions(+), 118 deletions(-) create mode > > > 100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > > delete mode 100644 > > > Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt > > > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > > b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml new file > > > mode > > > 100644 > > > index 000000000000..3da65d3ea4af > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > > @@ -0,0 +1,147 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > > +--- > > > +$id: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > > > +cetree.org%2Fschemas%2Fdma%2Ffsl%2Cimx-sdma.yaml%23&data=05 > > %7C01% > > > > > +7Cjoy.zou%40nxp.com%7Cc7a8409ee52447126b2908da8ff649db%7C686ea > > 1d3bc2b > > > > > +4c6fa92cd99c5c301635%7C0%7C0%7C637980585219845112%7CUnknown > > %7CTWFpbGZ > > > > > +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > > n0% > > > > > +3D%7C3000%7C%7C%7C&sdata=XHRpq%2BiZpXdB7Yw4gZRONgWMn7 > > KiSxM9yBES7R > > > +H0iNc%3D&reserved=0 > > > +$schema: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjoy.z > > ou%4 > > > > > +0nxp.com%7Cc7a8409ee52447126b2908da8ff649db%7C686ea1d3bc2b4c6f > > a92cd99 > > > > > +c5c301635%7C0%7C0%7C637980585220001350%7CUnknown%7CTWFpbG > > Zsb3d8eyJWIj > > > > > +oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000%7 > > > > > +C%7C%7C&sdata=6albMSOV7dsgaHuDk05ZUtAiMTlwYX6QyHrfXWz7%2 > > BmY%3D&am > > > +p;reserved=0 > > > + > > > +title: Freescale Smart Direct Memory Access (SDMA) Controller for > > > +i.MX > > > + > > > +maintainers: > > > + - Joy Zou <joy.zou@xxxxxxx> > > > + > > > +properties: > > > > Is it sensible to add something like this? > > > > $nodename: > > pattern: "^dma-controller(@.*)?$" > > > > You are changing the node names in patch 3 anyway. > Yes, it is sensible to add $nodename. Because I have deleted the dma-controller quotes. > I follow the dma-controller $nodename. I think it is general. So changing the node name. > I will add it next version. > Thanks for your comments! Instead, just add: allOf: - $ref: dma-controller.yaml# That will do the same thing. With that, Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Rob
