<Conor.Dooley@xxxxxxxxxxxxx> 於 2022年9月6日 週二 凌晨2:46寫道：
>
> Hey Zong Li,
> Couple comments on this patch.
>
> On 05/09/2022 09:31, Zong Li wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > From: Greentime Hu <greentime.hu@xxxxxxxxxx>
> >
> > Since composable cache may be L3 cache if pL2 cache exists, we should use
>
> What is a pL2 cache?
The pL2 is stand for private L2 cache, it is a L2 cache in our system.
Perhaps I should change the pL2 to L2 in the description for more
generic.
>
> > its original name composable cache to prevent confusion.
> >
> > Apart from renaming, we also add the compatible "sifive,ccache0" into ID
> > table.
> >
> > Signed-off-by: Greentime Hu <greentime.hu@xxxxxxxxxx>
> > Signed-off-by: Zong Li <zong.li@xxxxxxxxxx>
> > ---
> > drivers/soc/sifive/Kconfig | 6 +-
> > drivers/soc/sifive/Makefile | 2 +-
> > .../{sifive_l2_cache.c => sifive_ccache.c} | 163 +++++++++---------
> > .../{sifive_l2_cache.h => sifive_ccache.h} | 16 +-
> > 4 files changed, 94 insertions(+), 93 deletions(-)
> > rename drivers/soc/sifive/{sifive_l2_cache.c => sifive_ccache.c} (35%)
> > rename include/soc/sifive/{sifive_l2_cache.h => sifive_ccache.h} (12%)
>
> If you're going to rename the header, you need to update all references to
> it too, otherwise the other user (the EDAC) is going to have build issues,
> i.e. patch 6 needs to get squashed into this one.
>
Ok, let me merge these two patches, as you mentioned, we probably
don't want to see the build is broken in git bisect as well.
>
> > diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/sifive_ccache.c
> > similarity index 35%
> > rename from drivers/soc/sifive/sifive_l2_cache.c
> > rename to drivers/soc/sifive/sifive_ccache.c
> > index 59640a1d0b28..1b16a196547f 100644
> > --- a/drivers/soc/sifive/sifive_l2_cache.c
> > +++ b/drivers/soc/sifive/sifive_ccache.c
>
> > -static const struct of_device_id sifive_l2_ids[] = {
> > +static const struct of_device_id sifive_ccache_ids[] = {
> > { .compatible = "sifive,fu540-c000-ccache" },
> > { .compatible = "sifive,fu740-c000-ccache" },
> > + { .compatible = "sifive,ccache0" },
> > { /* end of table */ },
>
> For v3, I think you should drop the , from the end of the table while
> we are already editing it.
Thanks, I will remove it.
> Thanks,
> Conor.
>
> > };
> >
>
