On 02/09/2022 20:51, Andrew Halaney wrote: > Right now, running make dt_binding_check results in this snippet: > > /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: 'additionalProperties' is a required property > hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > SCHEMA Documentation/devicetree/bindings/processed-schema.json > <snip..> > /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: ignoring, error in schema: > > Which results in the schema not being properly evaluated. Swap out > unevaluatedProperties which doesn't seem to be doing anything for > additionalProperties. unevaluatedProperties were required due to usage of defs-allOf (ba5d99609a5e ("regulator: dt-bindings: qcom,rpmh: document supplies per variant") ). Are you sure that it works correctly with additionalProperties? Judging by errors it doesn't.... > > Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx> > --- > .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > index 9a36bee750af..b3fd60b21610 100644 > --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml > @@ -106,6 +106,8 @@ patternProperties: > $ref: "regulator.yaml#" > description: smps/ldo regulator nodes(s). > > +additionalProperties: false > + Don't move the location. The proper one is above examples. Best regards, Krzysztof
