On 05/09/2022 16:30, Abel Vesa wrote: > On 22-09-05 07:40:57, Rob Herring wrote: >> On Mon, 05 Sep 2022 13:37:14 +0300, Abel Vesa wrote: >>> Convert Qualcomm FastRPC bindings to yaml format, so that we could validate >>> dt-entries correctly and any future additions can go into yaml format. >>> >>> Use compute-cb@ subnodes instead of just cb@. >>> >>> Also add qcom,non-secure-domain, qcom,glink-channels and >>> qcom,smd-channels missing properties to make sure dtbs_check doesn't >>> fail right off the bat. >>> >>> Co-developed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> >>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> >>> Co-developed-by: David Heidelberg <david@xxxxxxx> >>> Signed-off-by: David Heidelberg <david@xxxxxxx> >>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> >>> --- >>> >>> Changes since v5: >>> * Removed the txt file >>> >>> .../devicetree/bindings/misc/qcom,fastrpc.txt | 88 -------------- >>> .../bindings/misc/qcom,fastrpc.yaml | 108 ++++++++++++++++++ >>> 2 files changed, 108 insertions(+), 88 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt >>> create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/qcom,fastrpc.example.dtb: smd-edge: 'qcom,smd-edge' is a required property >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/qcom,fastrpc.example.dtb: smd-edge: 'oneOf' conditional failed, one must be fixed: >> 'mboxes' is a required property >> 'qcom,ipc' is a required property >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/qcom,fastrpc.example.dtb: smd-edge: 'oneOf' conditional failed, one must be fixed: >> 'interrupts' is a required property >> 'interrupts-extended' is a required property >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml > > Right. > > So actually, the parent node is glink-edge, not smd-edge. > > And there are some other required properties missing when switching to > glink-edge. > > Will resend with glink-edge instead and add all the related missing > properties. BTW, if you need more fixes, just take over the patchset and add co-developed-by. Best regards, Krzysztof
