On Mon, Sep 5, 2022, at 12:43 PM, Sergei Antonov wrote:
> Driver moxart-mmc.c has .compatible = "moxa,moxart-mmc".
>
> But moxart.dtsi and the documentation file moxa,moxart-dma.txt
> contain another name: compatible = "moxa,moxart-sdhci".
>
> Change name in moxart.dtsi and moxa,moxart-dma.txt to that from the driver.
>
> Signed-off-by: Sergei Antonov <saproj@xxxxxxxxx>
> Cc: Jonas Jensen <jonas.jensen@xxxxxxxxx>
Something is clearly wrong here, as the moxart-mmc device is not
an sdhci at all, but are you sure that this is actually the
correct device?
> diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi
> index f5f070a87482..d69d73930ebe 100644
> --- a/arch/arm/boot/dts/moxart.dtsi
> +++ b/arch/arm/boot/dts/moxart.dtsi
> @@ -94,7 +94,7 @@ watchdog: watchdog@98500000 {
> };
>
> sdhci: sdhci@98e00000 {
> - compatible = "moxa,moxart-sdhci";
> + compatible = "moxa,moxart-mmc";
> reg = <0x98e00000 0x5C>;
> interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk_apb>;
Both the label and the device name still point to "sdhci",
so it would be possible that the SoC actually has both
an SDHCI compatible device and ftsdc010. In this case the
correct fix would be to add a second node for the
moxa,moxart-mmc with the correct reg and interrupts
properties but to leave this one alone.
Arnd
