On 03/09/2022 19:54, Iskren Chernev wrote: > > > On 9/1/22 19:11, Krzysztof Kozlowski wrote: >> On 01/09/2022 10:24, Iskren Chernev wrote: >>> Add SM6115 UFS to DT schema. >>> >>> Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> index f2d6298d926c..7c5f6e2e6d4c 100644 >>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> @@ -28,6 +28,7 @@ properties: >>> - qcom,msm8998-ufshc >>> - qcom,sc8280xp-ufshc >>> - qcom,sdm845-ufshc >>> + - qcom,sm6115-ufshc >>> - qcom,sm6350-ufshc >>> - qcom,sm8150-ufshc >>> - qcom,sm8250-ufshc >>> @@ -178,6 +179,31 @@ allOf: >>> minItems: 1 >>> maxItems: 1 >>> >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,sm6115-ufshc >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 8 >>> + maxItems: 8 >>> + clock-names: >>> + items: >>> + - const: core_clk >>> + - const: bus_aggr_clk >>> + - const: iface_clk >>> + - const: core_clk_unipro >>> + - const: core_clk_ice >> >> Use existing name and put it in the same place as existing variant - sdm845: >> ice_core_clk > > The only problem with sdm845 bindings is the presence of rx_lane1_sync_clk > clock. I'm guessing I could pass zeros there, because it shouldn't be used. Or > it could be moved to last property and then min/maxItems to guard, but that is > a change to something more-or-less immutable. I don't understand - what is the problem here. How presence of some clock affects name of other clock and its place/location in list of clocks? Best regards, Krzysztof
