On Thu, Sep 01, 2022 at 09:54:21AM +0300, Farber, Eliav wrote: > On 8/31/2022 3:14 PM, Andy Shevchenko wrote: > > On Tue, Aug 30, 2022 at 07:22:11PM +0000, Eliav Farber wrote: ... > > > + pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL); > > > > > + if (!pvt->dbgfs_dir) { > > > + dev_err(dev, "Failed to create dbgfs_dir\n"); > > > + return -EINVAL; > > > + } > > > > No, just don't check the return value of debugfs API calls. > > > Do you mean that I should just do: > debugfs_create_dir(dev_name(dev), NULL); > Can you please explain why it's OK to ignore the return value? Author of the debugfs is speaking: https://patchwork.kernel.org/project/linux-wireless/patch/20190122152151.16139-38-gregkh@xxxxxxxxxxxxxxxxxxx/ -- With Best Regards, Andy Shevchenko