On 01/09/2022 18:12, Russell King (Oracle) wrote:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - apple,t8103-smc
>>
>> You miss two spaces of indentation on this level.
>
> Should that be picked up by the dt checker?
I think yamllint complains about it. It is not a hard-dependency, so
maybe you don't have it installed.
>
>>> + - apple,t8112-smc
>>> + - apple,t6000-smc
>>
>> Bring some order here - either alphabetical or by date of release (as in
>> other Apple schemas). I think t6000 was before t8112, so it's none of
>> that orders.
>
> Ok.
>
>>> + - const: apple,smc
>>> +
>>> + reg:
>>> + description: Two regions, one for the SMC area and one for the SRAM area.
>>
>> You need constraints for size/order, so in this context list with
>> described items.
>
> How do I do that? I tried maxItems/minItems set to 2, but the dt checker
> objected to it.
One way:
reg:
items:
- description: SMC area
- description: SRAM area
but actually this is very similar what you wrote for reg-names - kind of
obvious, so easier way:
reg:
maxItems: 2
>
>>> + reg-names:
>>> + items:
>>> + - const: smc
>>> + - const: sram
>>> +
>>> + mboxes:
>>> + description:
>>> + A phandle to the mailbox channel
>>
>> Missing maxItems
>
> Ok. Would be helpful if the dt checker identified that.
Patches are welcomed :)
Best regards,
Krzysztof
