Re: [PATCH v3 17/19] hwmon: (mr75203) parse temperature coefficients from device-tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/31/2022 3:11 PM, Andy Shevchenko wrote:
On Tue, Aug 30, 2022 at 07:22:10PM +0000, Eliav Farber wrote:
Use thermal coefficients from the device tree if they exist.
Otherwise, use default values according to the series (5 or 6).
All coefficients can be used or only part of them.

The coefficients shall be used for fine tuning the default values since
coefficients can vary between product and product.

...

+     ret = of_property_read_u32(np, "moortec,ts-coeff-h", &coeff_h);

of_ ?! Ditto for the rest.


Fixed for v4.
I replaced it with device_property_read_u32().

+     if (!ret)
+             ts_coeff->h = coeff_h;

...

+     ret = of_property_read_s32(np, "moortec,ts-coeff-j", &coeff_j);
+     if (!ret)
+             ts_coeff->j = coeff_j;

You may avoid conditional:

       _property_read_s32(..., "moortec,ts-coeff-j", &ts_coeff->j);


Fixed for v4.
I removed the condition.

...

+     ret = of_property_read_u32(np, "moortec,ts-coeff-cal5", &coeff_cal5);
+     if (!ret) {

+             if (coeff_cal5 == 0) {
+                     dev_err(dev, "moortec,ts-coeff-cal5 can't be 0\n");
+                     return -EINVAL;
+             }

Code shouldn't be a YAML validator. Drop this and make sure you have correct
DT schema.


Fixed for v4.
I dropped the validation check.
The YAML already mentions that it can't be 0.

+             ts_coeff->cal5 = coeff_cal5;
+     }

--
Thanks, Eliav



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux