Hi Krzysztof, On Tue, 30 Aug 2022 at 15:21, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 29/08/2022 09:50, Anand Moon wrote: > > Add compatible string for RV1126 gmac, and constrain it to > > be compatible with Synopsys dwmac 4.20a. > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxx> > > Signed-off-by: Anand Moon <anand@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > index 083623c8d718..346e248a6ba5 100644 > > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > @@ -26,6 +26,7 @@ select: > > - rockchip,rk3399-gmac > > - rockchip,rk3568-gmac > > - rockchip,rv1108-gmac > > + - rockchip,rv1126-gmac > > That's not a complete change. What about the other place listing > compatibles? Did you test the bindings on your DTS? > Yes, I missed the properties menu, will update it in the next version. > > Best regards, > Krzysztof Thanks -Anand