On 8/22/22 11:19 AM, Krzysztof Kozlowski wrote: > On 20/08/2022 22:57, Brad Larson wrote: >> From: Brad Larson <blarson@xxxxxxx> >> >> The AMD Pensando Elba SoC has integrated the DW APB SPI Controller >> >> Signed-off-by: Brad Larson <blarson@xxxxxxx> >> --- >> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> index 37c3c272407d..403d6416f7ac 100644 >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> @@ -37,6 +37,15 @@ allOf: >> else: >> required: >> - interrupts >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - amd,pensando-elba-spi >> + then: >> + required: >> + - amd,pensando-elba-syscon > There is no such property. You cannot make it required without first > defining it. Added the definition of 'amd,pensando-elba-syscon' to snps,dw-apb-ssi.yaml >> properties: >> compatible: >> @@ -75,6 +84,8 @@ properties: >> - renesas,r9a06g032-spi # RZ/N1D >> - renesas,r9a06g033-spi # RZ/N1S >> - const: renesas,rzn1-spi # RZ/N1 >> + - description: AMD Pensando Elba SoC SPI Controller >> + const: amd,pensando-elba-spi > Don't add stuff at the end, but in some logical (usually alphabetical) > place. The order is already broken as everyone likes to add stuff in > conflict-style, so just add it before baikal, for example. Yes, tried to follow existing style. Will add it before baikal. Regards, Brad
