On 31/08/2022 17:37, Biju Das wrote:
> Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to
> FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1
> clock on fcpv. Introduce new compatibles renesas,r9a07g044-fcpvd
> for RZ/G2{L,LC} and renesas,r9a07g054-fcpvd for RZ/V2L to handle this
> difference.
>
> The 3 clocks are shared between du, vspd and fcpvd. Update the bindings
> to reflect this.
>
> No driver changes are required as generic compatible string
> "renesas,fcpv" will be used as a fallback.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v1->v2:
> * Documented RZ/{G2,V2}L FCPVD bindings
> * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd
> * Added clock-names property
> * described clocks.
> ---
> .../bindings/media/renesas,fcp.yaml | 46 +++++++++++++++++--
> 1 file changed, 41 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index 43f2fed8cd33..79a55694b2a2 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -21,15 +21,23 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - renesas,fcpv # FCP for VSP
> - - renesas,fcpf # FCP for FDP
> + oneOf:
> + - items:
No items here. You have just one item, so it is not a list.
> + - enum:
> + - renesas,fcpv # FCP for VSP
> + - renesas,fcpf # FCP for FDP
> +
> + - items:
> + - enum:
> + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
> + - renesas,r9a07g054-fcpvd # RZ/V2L
> + - const: renesas,fcpv # generic FCP for VSP fallback
>
> reg:
> maxItems: 1
>
> - clocks:
> - maxItems: 1
> + clocks: true
> + clock-names: true
Both should have here the widest constraints: minItems:1 and maxItems:3.
Best regards,
Krzysztof
