On Wed, Oct 08, 2014 at 10:33:29AM +0100, Lee Jones wrote:
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: David Paris <david.paris@xxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> .../devicetree/bindings/watchdog/st-lpc-wdt.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> new file mode 100644
> index 0000000..520ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st-lpc-wdt.txt
> @@ -0,0 +1,30 @@
> +STMicroelectronics LPC Watchdog
> +===============================
> +
> +Required properties
> +
> +- compatible : Must be one of:
> + "st,stih407-watchdog"
> + "st,stih416-watchdog"
> + "st,stih415-watchdog"
> + "st,stid127-watchdog"
> +- reg : LPC registers base address + range
s/range/size/
Please append something like "one entryfor each entry in reg-names".
> +- reg-names : Register map "base" and "syscfg-en" are compulsory. "type" is
> + platform dependent and not required for the STiH407
I don't understand the mention of "type".
Additionally, "syscfg-en" looks to be a portion of another device
(shared system controller?), and probably should be described by
reference.
> +- clock-names : Should be "lpc_wdt"
> +- clocks : Clock used by LPC device
> +- timeout-sec : Watchdog timeout in seconds
> +- st,syscfg : Syscfg node used to configure CPU reset type and mask
Does this relate to the syscfg-en entry in the reg proeprty?
> +- st,warm_reset : If present, reset type will be 'warm'. If not, it will be cold
s/_/-/ in property names.
Why does this need to be in the binding? It seems like a choice rather
than a property of the system.
Mark.
> +
> +Example:
> + watchdog@fde05000 {
> + compatible = "st,stih416-lpc-watchdog";
> + reg = <0xfde05000 0x1000> <0x204 0x4>;
> + reg-names = "base", "syscfg-en"
> + clock-names = "lpc_wdt";
> + clocks = <&clk_s_d3_flexgen CLK_LPC_0>;
> + timeout-sec = <600>;
> + st,syscfg = <&syscfg_core>;
> + st,warm_reset;
> + };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
