On 31/08/2022 10:49, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml > new file mode 100644 > index 000000000000..90c5e354f86c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml Filename: fsl,imx93-syscon.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: NXP i.MX9 Platforms System Controller bindings s/bindings// > + > +maintainers: > + - Peng Fan <peng.fan@xxxxxxx> > + Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). You miss here select. > +properties: > + compatible: > + oneOf: Drop oneOf, unless you already have patch adding something more? > + - items: > + - enum: > + - fsl,imx93-aonmix-ns-syscfg > + - fsl,imx93-wakeupmix-syscfg > + - const: syscon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg Best regards, Krzysztof
