On 31/08/2022 09:42, Horatiu Vultur wrote: > Document Lan9662 OTP controller. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> > --- > .../nvmem/microchip,lan9662-otpc.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml > new file mode 100644 > index 000000000000..def20733cf60 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/microchip,lan9662-otpc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN9662 OTP Controller (OTPC) > + > +maintainers: > + - Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> > + > +description: | > + OTP controller drives a NVMEM memory where system specific data > + (e.g. hardware configuration settings, chip identifiers) or > + user specific data could be stored. > + > +allOf: > + - $ref: nvmem.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: microchip,lan9662-otpc > + - const: microchip,lan9668-otpc > + - enum: > + - microchip,lan9662-otpc This is not what I wrote and this does not make sense. You now listed twice 9662 and 9668 does not have its entry. Best regards, Krzysztof