<Conor.Dooley@xxxxxxxxxxxxx> 於 2022年8月30日 週二 下午4:42寫道: > > On 29/08/2022 09:40, Zong Li wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Mon, Aug 29, 2022 at 3:05 PM <Conor.Dooley@xxxxxxxxxxxxx> wrote: > >> > >> Hey Zong, > >> > >> On 29/08/2022 07:22, Zong Li wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> > >>> From: Greentime Hu <greentime.hu@xxxxxxxxxx> > >>> > >>> Since composible cache may be L3 cache if pL2 cache exists, we should use > >>> its original name composible cache to prevent confusion. > >>> > >>> Signed-off-by: Greentime Hu <greentime.hu@xxxxxxxxxx> > >>> Signed-off-by: Zong Li <zong.li@xxxxxxxxxx> > > >>> > >>> diff --git a/drivers/soc/sifive/Kconfig b/drivers/soc/sifive/Kconfig > >>> index 58cf8c40d08d..3d65d2771f9a 100644 > >>> --- a/drivers/soc/sifive/Kconfig > >>> +++ b/drivers/soc/sifive/Kconfig > >>> @@ -2,9 +2,10 @@ > >>> > >>> if SOC_SIFIVE > >>> > >>> -config SIFIVE_L2 > >>> - bool "Sifive L2 Cache controller" > >>> +config SIFIVE_CCACHE > >>> + bool "Sifive composable Cache controller" > >>> + default y > >> > >> Changing this to default on is not a rename of the file.. > >> This should be in a different patch. > > > > Okay, let me separate it to another patch, but I guess we could remove > > it, and enable it by user. What is your perspective on it? > > Personally I would like to leave the default y out & leave it up > to the user - the driver is more informational than anything else > so I don't think making it default to on makes sense. > Agree, let me remove it in the next version. Thanks > > > >>> + > >>> +#define SIFIVE_CCACHE_DIRECCFIX_LOW 0x100 > >>> +#define SIFIVE_CCACHE_DIRECCFIX_HIGH 0x104 > >>> +#define SIFIVE_CCACHE_DIRECCFIX_COUNT 0x108 > >>> + > >>> +#define SIFIVE_CCACHE_DATECCFIX_LOW 0x140 > >>> +#define SIFIVE_CCACHE_DATECCFIX_HIGH 0x144 > >>> +#define SIFIVE_CCACHE_DATECCFIX_COUNT 0x148 > >>> + > >>> +#define SIFIVE_CCACHE_DATECCFAIL_LOW 0x160 > >>> +#define SIFIVE_CCACHE_DATECCFAIL_HIGH 0x164 > >>> +#define SIFIVE_CCACHE_DATECCFAIL_COUNT 0x168 > >>> + > >>> +#define SIFIVE_CCACHE_CONFIG 0x00 > >>> +#define SIFIVE_CCACHE_WAYENABLE 0x08 > >>> +#define SIFIVE_CCACHE_ECCINJECTERR 0x40 > >> > >> From what I can see, you've also changed these around too? > >> Please generate the patch's diff so that the rename is detected & the > >> diff shows only what changed in the file. The -M option is what you > >> are looking for. > >> > >> I have a couple other comments to make about what's changed here other, > >> thatn the rename but I will do so against a v2 where the diff is usable. > >> > > > > Let me sent the v2 patch, and separate the rename and diff part > > Great, thanks. I'll take another look at it then. > > Conor. > > _______________________________________________ > linux-riscv mailing list > linux-riscv@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-riscv