On Wed, Oct 08, 2014 at 10:41:36PM +0200, Christophe Henri RICARD wrote:
> Hi Jason,
>
> I have currently seen both. I agree on the principles as it is
> simplifying the code a little bit. I including this clean up in
> this patch Add devicetree structure for a future v2 submission
I was just looking at what the remaining lpcpd GPIO does, and..
1) I think you can probably just make this optional, if it is not
specified in the DT or through platform data, just don't fiddle with
it. This makes the driver much friendlier - ie it can be manually
attached via sysfs for instance.
2) This looks fishy:
static int tpm_st33_i2c_pm_suspend(struct device *dev)
if (power_mgt) {
gpio_set_value(pin_infos->io_lpcpd, 0);
} else {
ret = tpm_pm_suspend(dev);
}
I can't think of a reason why the driver wouldn't need to call
tpm_pm_suspend to save the internal state? Ditto for restore?
I'm also suspicious of the power_mgt module option, that should
probably go away entirely?
Jason
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
