On 30-08-2022 12:28, Jacek Anaszewski wrote:
Hi Oliver,
On 8/19/22 17:29, Olliver Schinagl wrote:
In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
added. However, there's a little more very common LED colors.
While the documentation states 'add what is missing', engineers tend to
be lazy and will just use what currently exists. So this patch will take
(a) list from online retailers [0], [1], [2] and use the common LED colors
from there, this being reasonable as this is what is currently available to
purchase.
Note, that LIME seems to be the modern take to 'Yellow-green' or
'Yellowish-green' from some older datasheets.
[0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
[1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
[2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
---
Changes since v1: Unbreak existing definitions.
include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index 3be89a7c20a9..04bf94523ea3 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -22,18 +22,22 @@
#define LEDS_BOOST_FIXED 2
/* Standard LED colors */
-#define LED_COLOR_ID_WHITE 0
-#define LED_COLOR_ID_RED 1
-#define LED_COLOR_ID_GREEN 2
-#define LED_COLOR_ID_BLUE 3
-#define LED_COLOR_ID_AMBER 4
-#define LED_COLOR_ID_VIOLET 5
-#define LED_COLOR_ID_YELLOW 6
-#define LED_COLOR_ID_IR 7
-#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
-#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
- so this would include RGBW and similar */
-#define LED_COLOR_ID_MAX 10
+#define LED_COLOR_ID_WHITE 0
+#define LED_COLOR_ID_RED 1
+#define LED_COLOR_ID_GREEN 2
+#define LED_COLOR_ID_BLUE 3
+#define LED_COLOR_ID_AMBER 4
+#define LED_COLOR_ID_VIOLET 5
+#define LED_COLOR_ID_YELLOW 6
+#define LED_COLOR_ID_IR 7
+#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
+#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, including RGBW etc. */
+#define LED_COLOR_ID_PUPRPLE 10
typo - as already mentioned
Sorry, I did not receive your earlier mail it seems, or it's not showing
up in the thread; well caught!
+#define LED_COLOR_ID_ORANGE 11
+#define LED_COLOR_ID_PINK 12
+#define LED_COLOR_ID_CYAN 13
+#define LED_COLOR_ID_LIME 14
+#define LED_COLOR_ID_MAX 15
/* Standard LED functions */
/* Keyboard LEDs, usually it would be input4::capslock etc. */
And it seems that change in spacing between definition name and value
is not required, is it? Without that change, it would be easier to
notice what really changes here.
Yes, you are correct, I initially had LimeGreen there, which made it
longer, as I later found out, that LimeGreen could actually just be Lime
as much, I forgot to 're-shorten it. The fixed diff for v4 does look as
expected! thanks for that one.
