Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 10, 2022 at 10:51:51PM -0400, Rudraksha Gupta wrote:
> > Clock and dts patches goes through two different paths towards mainline,
> 
> > so they should be separated.
> 
> Gotcha, thanks. I will do that.
> 
> 
> > This breaks compatibility with existing DTB files.
> 
> > What you probably want is to make sure that any clocks with parent name
> 
> > of "cxo", should have a .fw_name = "cxo", then you can make a
> 
> > phandle-based reference in DT and these global names doesn't matter (and
> 
> > in the end we can remove this board_clk from the driver).
> 
> Ah, I see. If I understand correctly, it should be something like this,
> right?
> https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L169-L172

Correct, this will try to find the clock by clock-names of "cxo" and if
not found fall back to do a lookup globally just on the name "xo_board".

So it seems making .name "cxo_board" should handle both cases nicely.

Regards,
Bjorn



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux