Hi
> Gesendet: Freitag, 26. August 2022 um 08:50 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx>
> On 25/08/2022 22:38, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > index 93d383b8be87..40b90c052634 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> > @@ -86,6 +86,66 @@ vcc5v0_sys: vcc5v0-sys {
> > vin-supply = <&dc_12v>;
> > };
> >
> > + pcie30_avdd0v9: pcie30-avdd0v9 {
>
> Use consistent naming, so if other nodes have "regulator" suffix, use it
> here as well.
only these 3 new have the suffix:
vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator
vcc3v3_minipcie: vcc3v3-minipcie-regulator
vcc3v3_ngff: vcc3v3-ngff-regulator
so i would drop it there...
so i end up with (including existing ones to compare):
vcc3v3_sys: vcc3v3-sys
vcc5v0_sys: vcc5v0-sys
pcie30_avdd0v9: pcie30-avdd0v9
pcie30_avdd1v8: pcie30-avdd1v8
vcc3v3_pi6c_05: vcc3v3-pi6c-05
vcc3v3_minipcie: vcc3v3-minipcie
vcc3v3_ngff: vcc3v3-ngff
vcc5v0_usb: vcc5v0_usb
vcc5v0_usb_host: vcc5v0-usb-host
vcc5v0_usb_otg: vcc5v0-usb-otg
is this ok?
maybe swap avdd* and pcie30 part to have voltage in front of function.
> > + compatible = "regulator-fixed";
> > + regulator-name = "pcie30_avdd0v9";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <900000>;
> > + regulator-max-microvolt = <900000>;
> > + vin-supply = <&vcc3v3_sys>;
> > + };
> > +
> > + pcie30_avdd1v8: pcie30-avdd1v8 {
>
> Ditto.
>
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "pcie30_avdd1v8";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + vin-supply = <&vcc3v3_sys>;
> > + };
> > +
> > + /* pi6c pcie clock generator feeds both ports */
> > + vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc3v3_pcie";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + enable-active-high;
> > + gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> > + startup-delay-us = <200000>;
> > + vin-supply = <&vcc5v0_sys>;
> > + };
> > +
>
> Best regards,
> Krzysztof
>
