On Fri, Aug 26, 2022 at 08:32:49AM +0200, Johannes Zink wrote: > On Thu, 2022-08-25 at 18:25 +0300, Ivan Bornyakov wrote: > > Hi, Johannes! > > Hi Ivan, > > > > I just came across your patches. Surprisingly, our work interferes. > > > > I recently posted patch-series for configuring ECP5 and was asked to > > make > > generalized sysCONFIG driver with support for both ECP5 and MachXO2, > > which > > I did. > > That looks very interesting indeed. > > > Sadly I don't have hardware with MachXO2, but you clearly do :) > > > > Please, take a look at > > > > > > https://lore.kernel.org/linux-fpga/20220825112433.14583-1-i.bornyakov@xxxxxxxxxxx/ > > > > and please help test MachXO2 variant. When we pull this off, you may > > add I2C > > interface on top. > > > > > > > > my hardware has only I2C connected to the MachXO2 (hence the patch > series...), so I cannot test your patches directly. That's unfortunate, anyway please join the review so your changes would be easier to apply on top. > > Since adding I2C requires some quirks with respect to the programming > commands (some are differ to the SPI ones, ...) it will take me some > time to add my patches on top of yours in order to test, but after > having had a short glance at your patch series, I think it should be > feasible. > > Though, I think you should allow the program-gpios, init-gpios and > done-gpios for machxo2 and have them as optional, at least for machxo2. > > Best regards > Johannes > > -- > Pengutronix e.K. | Johannes Zink | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | >
