Hello Daniel, Thank you for the feedback. I hope this information will explain better the LVTS Driver. I will add this like the following. Is this ok for you? [v9,7/7] thermal: mediatek: Add LVTS driver settings for mt8195 thermal zones One Clock and one Reset for Thermal. Thermal have two domain : CPU related (mcu) and non-CPU related (ap). TC : Thermal Controller to control the thermal sensor's HW behavior. TS : Thermal Sensor for measuring temperature the HW module. thermal ├── ap │ ├── tc_0 │ │ ├── TS4_0 - vpu1 │ │ └── TS4_1 - vpu2 │ ├── tc_1 │ │ ├── TS5_0 - gpu1 │ │ └── TS5_1 - gpu2 │ ├── tc_2 │ │ ├── TS6_0 - vdec │ │ ├── TS6_1 - img │ │ └── TS6_2 - infra │ └── tc_3 │ ├── TS7_0 - cam1 │ └── TS7_1 - cam2 └── mcu ├── tc_0 │ ├── TS1_0 - cpu_big1 │ └── TS1_1 - cpu_big2 ├── tc_1 │ ├── TS2_0 - cpu_big3 │ └── TS2_1 - cpu_big4 └── tc_2 ├── TS3_0 - cpu_little1 ├── TS3_1 - cpu_little2 ├── TS3_2 - cpu_little3 └── TS3_3 - cpu_little4 [v9,4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones One Clock and one Reset for Thermal. Thermal have two domain : CPU related (mcu) and non-CPU related (ap). TC : Thermal Controller to control the thermal sensor's HW behavior. TS : Thermal Sensor for measuring temperature the HW module. thermal ├── ap │ ├── tc_0 │ │ ├── TS4_0 - vpu1 │ │ └── TS4_1 - vpu2 │ ├── tc_1 │ │ ├── TS5_0 - gpu1 │ │ └── TS5_1 - gpu2 │ ├── tc_2 │ │ ├── TS6_0 - infra │ │ └── TS6_1 - cam │ └── tc_3 │ ├── TS7_0 - md2 │ └── TS7_1 - md3 | └── TS6_2 - md1 └── mcu ├── tc_0 │ ├── TS1_0 - cpu_big1 │ └── TS1_1 - cpu_big2 ├── tc_1 │ ├── TS2_0 - cpu_big3 │ └── TS2_1 - cpu_big4 └── tc_2 ├── TS3_0 - cpu_little1 ├── TS3_1 - cpu_little2 ├── TS3_2 - cpu_little3 └── TS3_3 - cpu_little4 Best regards, Balsam. On Thu, Aug 25, 2022 at 7:29 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > > > Hi Balsam, > > On 17/08/2022 10:07, bchihi@xxxxxxxxxxxx wrote: > > From: Michael Kao <michael.kao@xxxxxxxxxxxx> > > > > Add LVTS v4 (Low Voltage Thermal Sensor) driver to report junction > > temperatures in MediaTek SoC mt8192 and register the maximum temperature > > of sensors and each sensor as a thermal zone. > > Thanks for your work > > First of all, the patch is way too big. > > The organization of the data is hard to understand. > > Could you give a description of the sensors, how they are organized ? > > I can see the there are 'tc' and each have a group of sensing points? Is > that correct? Do have the 'tc's a shared clock? etc ... > > I have another email with the comments inline but without more insights > on the hardware it is difficult to review accurately. This driver looks > more complex than the other ones I've reviewed. At least that is what > looks like with the different macros names found. > > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
