On Tue, Oct 07, 2014 at 01:52:21PM +0100, Mark Brown wrote: > On Tue, Oct 07, 2014 at 02:11:07PM +0900, Gyungoh Yoo wrote: > > Signed-off-by: Gyungoh Yoo <jack.yoo@xxxxxxxxxxxxxxx> > > Several problems here: > > - I don't have patches 1-6 or the cover letter for this series - what > are the dependencies? > - I can't see any sign that my concerns about the driver not actually > being reusable have been addressed here. > - This patch appears to do way more than add a compatible string, for > example: I am sorry the recipients of each patch and cover letter was different. I will resubmit soon. > > > - np = of_get_child_by_name(dev->parent->of_node, "regulator"); > > - if (unlikely(!np)) { > > + if (!np) { > > dev_err(dev, "regulator node not found"); > > - return NULL; > > + return ERR_PTR(-ENODATA); -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html