Thanks Rob, I'll fix this up for v2. I ran sanity checks before submitting, but apparently not all the correct ones. On Tue, Aug 23, 2022 at 01:47:07PM -0500, Rob Herring wrote: > On Mon, 22 Aug 2022 23:00:52 -0700, Colin Foster wrote: > > Convert the phy-ocelot-serdes device tree binding to the new YAML format. > > > > Additionally, add the file to MAINTAINERS since the original file didn't > > exist. > > > > Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/phy/phy-ocelot-serdes.txt | 43 ------------- > > .../bindings/phy/phy-ocelot-serdes.yaml | 61 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 3 files changed, 62 insertions(+), 43 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.txt > > create mode 100644 Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: 'examlpes' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: 'oneOf' conditional failed, one must be fixed: > 'unevaluatedProperties' is a required property > 'additionalProperties' is a required property > hint: Either unevaluatedProperties or additionalProperties must be present > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-ocelot-serdes.yaml: ignoring, error in schema: > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
