On Tue 07 Oct 02:54 PDT 2014, Kiran Padwal wrote:
> On Tuesday 07 October 2014 06:42 AM, Bjorn Andersson wrote:
> > From: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
> >
> > Signed-off-by: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> > ---
> > drivers/input/misc/Kconfig | 12 +++
> > drivers/input/misc/Makefile | 1 +
> > drivers/input/misc/pm8941-pwrkey.c | 196 ++++++++++++++++++++++++++++++++++++
>
> <snip>
>
> > +
> > + platform_set_drvdata(pdev, pwrkey);
> > + device_init_wakeup(&pdev->dev, 1);
> > +
> > + return 0;
> > +}
> > +
> > +static int pm8941_pwrkey_remove(struct platform_device *pdev)
> > +{
> > + device_init_wakeup(&pdev->dev, 0);
>
> Shouldn't we unregister input device?
>
It's allocated with devm_input_allocate_device() so I assumed that it goes away
upon the device being removed. Looking at input_register_device() seems to
confirm that.
> > +
> > + return 0;
> > +}
> > +
> > +static const struct of_device_id pm8941_pwr_key_id_table[] = {
> > + { .compatible = "qcom,pm8941-pwrkey" },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(of, pm8941_pwr_key_id_table);
> > +
> > +static struct platform_driver pm8941_pwrkey_driver = {
> > + .probe = pm8941_pwrkey_probe,
> > + .remove = pm8941_pwrkey_remove,
> > + .driver = {
> > + .name = "pm8941-pwrkey",
> > + .owner = THIS_MODULE,
>
> This field can be removed because this driver which use the
> module_platform_driver api as this is overridden in
> platform_driver_register.
>
Thanks
> > + .pm = &pm8941_pwr_key_pm_ops,
> > + .of_match_table = of_match_ptr(pm8941_pwr_key_id_table),
> > + },
> > +};
> > +module_platform_driver(pm8941_pwrkey_driver);
> > +
> > +MODULE_DESCRIPTION("PM8941 Power Key driver");
> > +MODULE_LICENSE("GPL v2");
>
> May be you can add module author name.
>
Courtney based this driver on the skeleton from pmic8xxx-pwrkey, so I don't
think it's right to say that there's any particular author. And you have the
git log...
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
