On 22/08/2022 22:04, Dmitry Baryshkov wrote: >>> required: >>> - compatible >>> - reg >>> @@ -177,7 +204,19 @@ patternProperties: >>> # TODO: add reference once the mdp5 is converted >>> >>> "^display-controller@(0|[1-9a-f][0-9a-f]*)$": >>> - $ref: dpu-sdm845.yaml >>> + oneOf: >>> + - $ref: dpu-sc7180.yaml >>> + - $ref: dpu-sdm845.yaml >> >> I don't think this is good approach. These are strictly tied, so you >> should have rather per SoC MDSS schema pulling in: >> 1. common MDSS >> 2. specific children schemas >> >> This makes it quite obvious and specific. Your setup now allows putting >> sc7180-dpu under sdm845-dpu. > > Then we should probably also use very specific $ref and compat check for > all other entries in this file too. I understand your concern, however > I'd prefer to have the working schema which is not tight enough compared > to set of schema files that completely do not work. Why they cannot be tight and working? > And current > dpu-*yaml do not work as they allow just the display-controller beneath > the mdss node. Sure, this can be fixed but not really in a relaxing way. > > If you absolutely insist on me making the binding tight enough, I'll > rework the bindings to clearly specify which SoC has which nodes. I do not see the drawbacks of specific/tight approach, so yes, please make it tight. Best regards, Krzysztof
