On Mon, Aug 22, 2022 at 02:20:32PM -0500, Rob Herring wrote:
> On Sat, 20 Aug 2022 00:14:10 +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >
> > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix
> > 'unevaluatedProperties' warnings") removed the clock-names property as
> > a requirement and from the example as it triggered unevaluatedProperty
> > warnings. dtbs_check was not able to pick up on this at the time, but
> > now can:
> >
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
> > From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> >
> > The property was already in use by the FU740 DTS and the clock must be
> > enabled. The Linux and FreeBSD drivers require the property to enable
> > the clocks correctly Re-add the property and its "clocks" dependency,
> > while making it required.
> >
> > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings")
> > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host controller")
> > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > ---
> > v2022.08 of dt-schema is required.
> > ---
> > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Should I pick these bindings updates up ?
Lorenzo
