Re: [PATCH] ARM: dts: am5748: keep usb4_tm disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Le 23/08/2022 à 07:53, Tony Lindgren a écrit :
> Hi,
> 
> * Romain Naour <romain.naour@xxxxxxxx> [220822 15:39]:
>> From: Romain Naour <romain.naour@xxxxxxx>
>>
>> From [1]
>> AM5 and DRA7 SoC families have different set of modules in them so the
>> SoC sepecific dtsi files need to be separated.
>>
>> e.g. Some of the major differences between AM576 and DRA76
>>
>> 		DRA76x	AM576x
>>
>> USB3		x
>> USB4		x
>> ATL		x
>> VCP		x
>> MLB		x
>> ISS		x
>> PRU-ICSS1		x
>> PRU-ICSS2		x
>>
>> But commit [2] removed usb4_tm part from am5748.dtsi and introcuded new
>> ti-sysc errors in dmesg.
> 
> OK makes sense to me. Can you please update your patch to use proper
> Fixes tags and commit descriptions? This way the patch will get
> automatically picked up for stable kernels as a fix.
> 
> So something like this instead of listing URLs to commits:
> 
> Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files") blah
> blah, then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
> package") blah blah...
> 
> Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")

Thanks for the review!

I just sent a new patch with updated commit log.

Best regards,
Romain


> 
> Regards,
> 
> Tony




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux