Re: [PATCH v7 4/4] PCI: endpoint: Add NTB MSI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frank,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jonmason-ntb/ntb-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822]
[cannot apply to tip/irq/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220822-235323
base:   https://github.com/jonmason/ntb ntb-next
config: s390-randconfig-s053-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230844.D25Fw8sg-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/d98704aefa5b57814d7b9b1b40160df34977b2b6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220822-235323
        git checkout d98704aefa5b57814d7b9b1b40160df34977b2b6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/endpoint/functions/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

sparse warnings: (new ones prefixed by >>)
>> drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void [noderef] __iomem *[assigned] mw_addr @@     got void * @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse:     expected void [noderef] __iomem *[assigned] mw_addr
   drivers/pci/endpoint/functions/pci-epf-vntb.c:567:25: sparse:     got void *
   drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void *addr @@     got void [noderef] __iomem *epf_db @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse:     expected void *addr
   drivers/pci/endpoint/functions/pci-epf-vntb.c:600:41: sparse:     got void [noderef] __iomem *epf_db
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1201:33: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __iomem *base @@     got struct epf_ntb_ctrl *reg @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1201:33: sparse:     expected void [noderef] __iomem *base
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1201:33: sparse:     got struct epf_ntb_ctrl *reg
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1212:33: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __iomem *base @@     got struct epf_ntb_ctrl *reg @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1212:33: sparse:     expected void [noderef] __iomem *base
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1212:33: sparse:     got struct epf_ntb_ctrl *reg
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1223:33: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __iomem *base @@     got struct epf_ntb_ctrl *reg @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1223:33: sparse:     expected void [noderef] __iomem *base
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1223:33: sparse:     got struct epf_ntb_ctrl *reg
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1235:33: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __iomem *base @@     got struct epf_ntb_ctrl *reg @@
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1235:33: sparse:     expected void [noderef] __iomem *base
   drivers/pci/endpoint/functions/pci-epf-vntb.c:1235:33: sparse:     got struct epf_ntb_ctrl *reg

vim +567 drivers/pci/endpoint/functions/pci-epf-vntb.c

d98704aefa5b578 Frank Li 2022-08-22  536  
e35f56bb03304ab Frank Li 2022-02-22  537  /**
e35f56bb03304ab Frank Li 2022-02-22  538   * epf_ntb_db_bar_init() - Configure Doorbell window BARs
e35f56bb03304ab Frank Li 2022-02-22  539   * @ntb: NTB device that facilitates communication between HOST and vHOST
e35f56bb03304ab Frank Li 2022-02-22  540   */
e35f56bb03304ab Frank Li 2022-02-22  541  static int epf_ntb_db_bar_init(struct epf_ntb *ntb)
e35f56bb03304ab Frank Li 2022-02-22  542  {
e35f56bb03304ab Frank Li 2022-02-22  543  	const struct pci_epc_features *epc_features;
e35f56bb03304ab Frank Li 2022-02-22  544  	u32 align;
e35f56bb03304ab Frank Li 2022-02-22  545  	struct device *dev = &ntb->epf->dev;
e35f56bb03304ab Frank Li 2022-02-22  546  	int ret;
e35f56bb03304ab Frank Li 2022-02-22  547  	struct pci_epf_bar *epf_bar;
e35f56bb03304ab Frank Li 2022-02-22  548  	void __iomem *mw_addr;
e35f56bb03304ab Frank Li 2022-02-22  549  	enum pci_barno barno;
d98704aefa5b578 Frank Li 2022-08-22  550  	size_t size;
e35f56bb03304ab Frank Li 2022-02-22  551  
e35f56bb03304ab Frank Li 2022-02-22  552  	epc_features = pci_epc_get_features(ntb->epf->epc,
e35f56bb03304ab Frank Li 2022-02-22  553  					    ntb->epf->func_no,
e35f56bb03304ab Frank Li 2022-02-22  554  					    ntb->epf->vfunc_no);
e35f56bb03304ab Frank Li 2022-02-22  555  	align = epc_features->align;
d98704aefa5b578 Frank Li 2022-08-22  556  	size = epf_ntb_db_size(ntb);
e35f56bb03304ab Frank Li 2022-02-22  557  
e35f56bb03304ab Frank Li 2022-02-22  558  	barno = ntb->epf_ntb_bar[BAR_DB];
d98704aefa5b578 Frank Li 2022-08-22  559  	epf_bar = &ntb->epf->bar[barno];
e35f56bb03304ab Frank Li 2022-02-22  560  
d98704aefa5b578 Frank Li 2022-08-22  561  	if (ntb->epf_db_phy) {
d98704aefa5b578 Frank Li 2022-08-22  562  		mw_addr = NULL;
d98704aefa5b578 Frank Li 2022-08-22  563  		epf_bar->phys_addr = ntb->epf_db_phy;
d98704aefa5b578 Frank Li 2022-08-22  564  		epf_bar->barno = barno;
d98704aefa5b578 Frank Li 2022-08-22  565  		epf_bar->size = size;
d98704aefa5b578 Frank Li 2022-08-22  566  	} else {
e35f56bb03304ab Frank Li 2022-02-22 @567  		mw_addr = pci_epf_alloc_space(ntb->epf, size, barno, align, 0);
e35f56bb03304ab Frank Li 2022-02-22  568  		if (!mw_addr) {
e35f56bb03304ab Frank Li 2022-02-22  569  			dev_err(dev, "Failed to allocate OB address\n");
e35f56bb03304ab Frank Li 2022-02-22  570  			return -ENOMEM;
e35f56bb03304ab Frank Li 2022-02-22  571  		}
d98704aefa5b578 Frank Li 2022-08-22  572  	}
e35f56bb03304ab Frank Li 2022-02-22  573  
e35f56bb03304ab Frank Li 2022-02-22  574  	ntb->epf_db = mw_addr;
e35f56bb03304ab Frank Li 2022-02-22  575  
e35f56bb03304ab Frank Li 2022-02-22  576  	ret = pci_epc_set_bar(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no, epf_bar);
e35f56bb03304ab Frank Li 2022-02-22  577  	if (ret) {
e35f56bb03304ab Frank Li 2022-02-22  578  		dev_err(dev, "Doorbell BAR set failed\n");
e35f56bb03304ab Frank Li 2022-02-22  579  			goto err_alloc_peer_mem;
e35f56bb03304ab Frank Li 2022-02-22  580  	}
e35f56bb03304ab Frank Li 2022-02-22  581  	return ret;
e35f56bb03304ab Frank Li 2022-02-22  582  
e35f56bb03304ab Frank Li 2022-02-22  583  err_alloc_peer_mem:
e35f56bb03304ab Frank Li 2022-02-22  584  	pci_epc_mem_free_addr(ntb->epf->epc, epf_bar->phys_addr, mw_addr, epf_bar->size);
e35f56bb03304ab Frank Li 2022-02-22  585  	return -1;
e35f56bb03304ab Frank Li 2022-02-22  586  }
e35f56bb03304ab Frank Li 2022-02-22  587  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux