Re: [PATCH v2 8/9] dt-bindings: msm/dp: add missing properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/07/2022 02:16, Rob Herring wrote:
On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote:
Document missing definitions for opp-table (DP controller OPPs), aux-bus
(DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties.

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  .../bindings/display/msm/dp-controller.yaml          | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 391910d91e43..52cbf00df0ba 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -70,9 +70,21 @@ properties:
    operating-points-v2:
      maxItems: 1
+ opp-table: true
+
    power-domains:
      maxItems: 1
+ aux-bus:
+    $ref: /schemas/display/dp-aux-bus.yaml#
+
+  data-lanes:

But this is the wrong location for 'data-lanes'. It belongs in an
endpoint node.

I rechecked the existing device trees (sc7280-herobrine.dtsi). The data-lanes are already inside the main dp controller node. I'll take a glance on fixing the driver to check the dp_out endpoint (and update existing DT to move the property to the endpoint node), but to make schema compatible with the existing device trees we'd probably still need this property (which can be marked as deprecated once the proper endpoint property is supported). Does that sound plausible?


+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 1
+    maxItems: 4
+    items:
+      maximum: 3
+
    "#sound-dai-cells":
      const: 0
--
2.35.1



--
With best wishes
Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux