Hi Jernej, On Tue, Aug 16, 2022 at 11:28 AM Jernej Škrabec <jernej.skrabec@xxxxxxxxx> wrote: > Dne torek, 16. avgust 2022 ob 11:12:05 CEST je Heiko Stübner napisal(a): > > Am Dienstag, 16. August 2022, 09:49:58 CEST schrieb Jernej Škrabec: > > > Dne torek, 16. avgust 2022 ob 09:41:45 CEST je Krzysztof Kozlowski > napisal(a): > > > > On 15/08/2022 08:08, Samuel Holland wrote: > > > > > + > > > > > + de: display-engine { > > > > > + compatible = "allwinner,sun20i-d1-display-engine"; > > > > > + allwinner,pipelines = <&mixer0>, <&mixer1>; > > > > > + status = "disabled"; > > > > > + }; > > > > > + > > > > > + osc24M: osc24M-clk { > > > > > > > > lowercase > > > > > > > > > + compatible = "fixed-clock"; > > > > > + clock-frequency = <24000000>; > > > > > > > > This is a property of the board, not SoC. > > > > > > SoC needs 24 MHz oscillator for correct operation, so each and every board > > > has it. Having it here simplifies board DT files. > > > > I guess the oscillator is a separate component on each board, right? > > Correct. > > > And DT obvious is meant to describe the hardware - independently from > > implementation-specific choices. > > There is no choice in this case. 24 MHz crystal has to be present. > > FWIW, including crystal node in SoC specific DTSI is already common pattern in > Allwinner ARM SoC DTSI files. I could also be a programmable clock generator on the board, programmed to generate a 24 MHz clock on one of its outputs? Again, on the board. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds