On Wed, Aug 17, 2022 at 12:10 PM Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx> wrote: > > slg7xl45106 is a I2C GPO expander. > Add a compatible string for the same. Also update the > driver to write and read from it. ... > + struct device_node *np = client->dev.of_node; > + if (of_device_is_compatible(np, "dlg,slg7xl45106")) > + gpio->command = SLG7XL45106_GPO_REG; Please, avoid making the driver OF dependent when there is no reason to do that. Note, we have device property and fwnode APIs that may cover a lot of cases for different property providers. -- With Best Regards, Andy Shevchenko
