On 8/18/2022 11:28 PM, Guenter Roeck wrote:
The calculation was just changed to use new defaults in a previous patch. This patch makes it quite clear that the coefficients are implementation (?) dependent. So the previous patch just changes the defaults to (presumably) the coefficients used in your system. That is inappropriate. Adding non-default corefficients is ok and makes sense is supported by the chip, but changing defaults isn't.
The calculation was changed in previous patch to match series 5 of the Moortec Embedded Temperature Sensor (METS) datasheet. In our SOC we use series 6 which has a slightly different equation and different coefficients. I did the changes in steps. With this last change, both series 5 and 6 are supported, in addition to calibrated vs. non-calibrated modes. In addition the data sheet just recommends default values but they also specifically mention that actual values might vary from product to product. -- Regards, Eliav