On Thu, 2022-08-18 at 13:02 +0200, Hans Verkuil wrote: > Hi Moudy, > > I noticed one more thing (and it is probably better to post a v26 > after all): > > On 17/08/2022 11:56, Moudy Ho wrote: > > This patch adds driver for MediaTek's Media Data Path ver.3 (MDP3). > > It provides the following functions: > > color transform, format conversion, resize, crop, rotate, flip > > and additional image quality enhancement. > > > > The MDP3 driver is mainly used for Google Chromebook products to > > import the new architecture to set the HW settings as shown below: > > User -> V4L2 framework > > -> MDP3 driver -> SCP (setting calculations) > > -> MDP3 driver -> CMDQ (GCE driver) -> HW > > > > Each modules' related operation control is sited in mtk-mdp3-comp.c > > Each modules' register table is defined in file with "mdp_reg_" > > prefix > > GCE related API, operation control sited in mtk-mdp3-cmdq.c > > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c > > Probe, power, suspend/resume, system level functions are defined in > > mtk-mdp3-core.c > > > > v4l2-compliance 1.22.1, 32 bits, 32-bit time_t > > First of all, the v4l2-compliance output belongs to the cover letter, > not > to a commit log for a patch. > > More importantly, I can tell that v4l2-compliance was a prepackaged > version, > but you need to compile it from the git repo yourself: > > git clone git://linuxtv.org/v4l-utils.git > cd v4l-utils > ./bootstrap.sh > ./configure > make > sudo make install > > Running v4l2-compliance should start with this (or something close): > > v4l2-compliance 1.23.0-4941, 64 bits, 64-bit time_t > v4l2-compliance SHA: 71112d214762 2022-07-28 15:31:13 > > I need to see the SHA to confirm that you tested with a sufficiently > new > v4l2-compliance version. Prepackaged v4l2-compliance binaries tend to > be too old, at least for the purpose of compliance checking a new > driver. > > Regards, > > Hans > Hello Hans, Because there are some issues for Moudy's mail account, I help him reply the mail: Thanks for your review and comment, those two errors you mentioned have been corrected accordingly. I will test it with the latest version of v4l2-compliance, and it will be released in v26 together with the testing report. BRs, Bo-Chen > > Compliance test for mtk-mdp3 device /dev/video0: > > Driver Info: > > Driver name : mtk-mdp3 > > Card type : MediaTek MDP3 > > Bus info : platform:14001000.mdp3-rdma0 > > Driver version : 6.0.0 > > Capabilities : 0x84204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Device Capabilities > > Device Caps : 0x04204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > >
