On 2022-08-17 at 12:04:13 +0300, Ivan Bornyakov wrote: > On Tue, Aug 16, 2022 at 02:09:18PM +0800, Xu Yilun wrote: > > On 2022-08-16 at 07:58:41 +0300, Ivan Bornyakov wrote: > > > On Tue, Aug 16, 2022 at 10:00:41AM +0800, Xu Yilun wrote: > > > > On 2022-08-15 at 16:21:56 +0300, Ivan Bornyakov wrote: > > > > > Add support to the FPGA manager for programming Lattice ECP5 FPGA over > > > > > slave SPI interface with .bit formatted uncompressed bitstream image. > > > > > > > > Not sure if something is missed. > > > > > > > > https://lore.kernel.org/all/20220729145757.GA2601292@yilunxu-OptiPlex-7050/ > > > > > > > > I was considering if a generic driver for lattice slave SPI sysCONFIG > > > > interface could be introduced. From machxo2 & ecp5 Programming Usage > > > > Guide, or others in this series, they basically use the same reconfigure > > > > interface & protocol. > > > > > > > > Thanks, > > > > Yilun > > > > > > > > > > I only have HW with ECP5, can't vouch for the rest. > > > > I understand your concern, but having separate drivers for the same IP on > > different boards makes the maintaining harder. > > > > We don't have to make everything fine, but start with machxo2 and ecp5 > > first. If the change affects machxo2, other people may help. > > > > Thanks, > > Yilun > > > > Hi, Yilun. > > To clear things out, considering what Daniel said in > https://lore.kernel.org/linux-fpga/20220816074216.GA31706@xxxxxxxxxxxxxxx/ > you still don't want separate ECP5 driver, or this v6 is OK and review I still perfer one sysCONFIG driver. If I understand right, the 2 reprogramming modes and the command sets are within the scope of sysCONFIG spec. So they could be all supported in sysCONFIG driver, and I assume some config option could be made to adapt different boards. Thanks, Yilun > continues? >
