On Mon, Jul 04, 2022 at 11:12:09AM +0200, Krzysztof Kozlowski wrote: > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > > index daa2f79a294f..6642c246951b 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > > @@ -40,6 +40,10 @@ properties: > > - enum: > > - fsl,imx7d-fec > > - const: fsl,imx6sx-fec > > + - items: > > + - enum: > > + - fsl,imx8ulp-fec > > + - const: fsl,imx6ul-fec > > This is wrong. fsl,imx6ul-fec has to be followed by fsl,imx6q-fec. I > think someone made similar mistakes earlier so this is a mess. Hmm, not sure I follow this. Supposing we want to have the following compatible for i.MX8ULP FEC, why do we have to have "fsl,imx6q-fec" here? fec: ethernet@29950000 { compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec"; ... }; Shawn > > > - items: > > - const: fsl,imx8mq-fec > > - const: fsl,imx6sx-fec